Skip to content

Add Atom as IDE option #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oskosk wants to merge 1 commit into from
Closed

Add Atom as IDE option #91

oskosk wants to merge 1 commit into from

Conversation

@oskosk
Copy link

@oskosk oskosk commented Mar 8, 2018

Fixes #90

Adds a new option Atom + php-debug with value xdebug-atom to the IDE select.

Changes introduced by this PR

  • Adds a new option with value xdebug-atom to the IDE select in options.html
  • Adds a new comparison against the value xdebug-atom for the idekey var in option.js/restore_options()

Screenshots

New option value:

image

Cookie being sent properly:

image

Select working correctly with new value

select

@oskosk oskosk mentioned this pull request Mar 8, 2018
Open
@oskosk oskosk closed this by deleting the head repository Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add option in select for IDE key used by Atom + php-debug package

1 participant

@oskosk